From d8cbc0aaeef6eb739b3779caf7770250fbd46afc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=B6rg=20Krzeslak?= Date: Thu, 24 Jul 2025 18:02:13 +0200 Subject: [PATCH] test: add unit test for resvg.ts --- src/converters/potrace.ts | 2 +- src/converters/resvg.ts | 5 +++-- tests/converters/resvg.test.ts | 19 +++++++++++++++++++ 3 files changed, 23 insertions(+), 3 deletions(-) create mode 100644 tests/converters/resvg.test.ts diff --git a/src/converters/potrace.ts b/src/converters/potrace.ts index bc90503..6027491 100644 --- a/src/converters/potrace.ts +++ b/src/converters/potrace.ts @@ -28,7 +28,7 @@ export function convert( convertTo: string, targetPath: string, options?: unknown, - execFile: ExecFileFn = execFileOriginal, + execFile: ExecFileFn = execFileOriginal, // to make it mockable ): Promise { return new Promise((resolve, reject) => { execFile("potrace", [filePath, "-o", targetPath, "-b", convertTo], (error, stdout, stderr) => { diff --git a/src/converters/resvg.ts b/src/converters/resvg.ts index 1e409cb..3155483 100644 --- a/src/converters/resvg.ts +++ b/src/converters/resvg.ts @@ -1,4 +1,5 @@ -import { execFile } from "node:child_process"; +import { execFile as execFileOriginal } from "node:child_process"; +import { ExecFileFn } from "./types.ts"; export const properties = { from: { @@ -14,8 +15,8 @@ export function convert( fileType: string, convertTo: string, targetPath: string, - // eslint-disable-next-line @typescript-eslint/no-unused-vars options?: unknown, + execFile: ExecFileFn = execFileOriginal, // to make it mockable ): Promise { return new Promise((resolve, reject) => { execFile("resvg", [filePath, targetPath], (error, stdout, stderr) => { diff --git a/tests/converters/resvg.test.ts b/tests/converters/resvg.test.ts new file mode 100644 index 0000000..d2eae2f --- /dev/null +++ b/tests/converters/resvg.test.ts @@ -0,0 +1,19 @@ +import { test } from "bun:test"; +import { convert } from "../../src/converters/resvg.ts"; +import { + runConvertFailTest, + runConvertLogsStderror, + runConvertSuccessTest, +} from "./helpers/converters.ts"; + +test("convert resolves when execFile succeeds", async () => { + await runConvertSuccessTest(convert); +}); + +test("convert rejects when execFile fails", async () => { + await runConvertFailTest(convert); +}); + +test("convert logs stderr when present", async () => { + await runConvertLogsStderror(convert); +});