From e6f8bea804f94e453f06212cfb970264a3191ec0 Mon Sep 17 00:00:00 2001 From: Antoni Ros Zafont Date: Fri, 16 Jan 2026 20:42:10 +0100 Subject: [PATCH] Fix to Fix error in previous fix, and adapt tests --- src/converters/libreoffice.ts | 4 +++- tests/converters/libreoffice.test.ts | 5 ++--- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/src/converters/libreoffice.ts b/src/converters/libreoffice.ts index ff51f93..1fd6488 100644 --- a/src/converters/libreoffice.ts +++ b/src/converters/libreoffice.ts @@ -124,7 +124,9 @@ const filters: Record> = { }; const getFilters = (fileType: string, converto: string) => { - if (fileType in filters.text && converto in filters.text) { + if (converto === "pdf") { + return [null, null]; + } else if (fileType in filters.text && converto in filters.text) { return [filters.text[fileType], filters.text[converto]]; } else if (fileType in filters.calc && converto in filters.calc) { return [filters.calc[fileType], filters.calc[converto]]; diff --git a/tests/converters/libreoffice.test.ts b/tests/converters/libreoffice.test.ts index 4d07f1e..d5ead05 100644 --- a/tests/converters/libreoffice.test.ts +++ b/tests/converters/libreoffice.test.ts @@ -63,7 +63,7 @@ test("invokes soffice with --headless and outdir derived from targetPath", async expect(cmd).toBe("soffice"); expect(args).toEqual([ "--headless", - `--infilter="MS Word 2007 XML"`, + `--infilter=MS Word 2007 XML`, "--convert-to", "odt:writer8", "--outdir", @@ -77,8 +77,7 @@ test("uses only outFilter when input has no filter (e.g., pdf -> txt)", async () const { args } = requireDefined(calls[0], "Expected at least one execFile call"); - expect(args).not.toContainEqual(expect.stringMatching(/^--infilter=/)); - expect(args).toEqual(["--headless", "--convert-to", "txt", "--outdir", "out", "in.pdf"]); + expect(args).toEqual(["--headless", "--infilter=writer_pdf_import","--convert-to", "txt:Text", "--outdir", "out", "in.pdf"]); }); test("uses only infilter when convertTo has no out filter (e.g., docx -> pdf)", async () => {