chore: implement Phase 1 and 2 security remediations
Some checks failed
Automated Container Build / build-and-push (push) Has been cancelled
Some checks failed
Automated Container Build / build-and-push (push) Has been cancelled
This commit is contained in:
parent
82731e93b1
commit
701766b611
14 changed files with 213 additions and 55 deletions
51
backend/handlers/urlvalidation.go
Normal file
51
backend/handlers/urlvalidation.go
Normal file
|
|
@ -0,0 +1,51 @@
|
|||
package handlers
|
||||
|
||||
import (
|
||||
"fmt"
|
||||
"net"
|
||||
"net/url"
|
||||
"strings"
|
||||
)
|
||||
|
||||
// validateCallbackURL ensures the URL points to a trusted OnlyOffice Document Server
|
||||
// and is not targeting internal/private network addresses.
|
||||
func validateCallbackURL(rawURL string, trustedHosts []string) error {
|
||||
parsed, err := url.Parse(rawURL)
|
||||
if err != nil {
|
||||
return fmt.Errorf("invalid URL: %w", err)
|
||||
}
|
||||
|
||||
// Require HTTPS (or HTTP for Docker-internal communication)
|
||||
if parsed.Scheme != "https" && parsed.Scheme != "http" {
|
||||
return fmt.Errorf("unsupported scheme: %s", parsed.Scheme)
|
||||
}
|
||||
|
||||
// Check against trusted hosts
|
||||
hostname := parsed.Hostname()
|
||||
trusted := false
|
||||
for _, h := range trustedHosts {
|
||||
if strings.EqualFold(hostname, h) {
|
||||
trusted = true
|
||||
break
|
||||
}
|
||||
}
|
||||
if !trusted {
|
||||
return fmt.Errorf("untrusted host: %s", hostname)
|
||||
}
|
||||
|
||||
// Resolve DNS and block private/loopback IPs to prevent DNS rebinding
|
||||
ips, err := net.LookupIP(hostname)
|
||||
if err != nil {
|
||||
return fmt.Errorf("DNS resolution failed: %w", err)
|
||||
}
|
||||
for _, ip := range ips {
|
||||
if ip.IsLoopback() || ip.IsPrivate() || ip.IsLinkLocalUnicast() {
|
||||
// Allow private IPs only if the trusted host is explicitly an IP
|
||||
if net.ParseIP(hostname) == nil {
|
||||
return fmt.Errorf("resolved to private IP: %s", ip)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
return nil
|
||||
}
|
||||
Reference in a new issue