Address code review feedback from cubic-dev-ai: P1: Unconditionally passing CJKmainfont broke non-CJK conversions in environments without CJK fonts. Now the source file is scanned for CJK characters and the font argument is only added when CJK content is detected. P2: Hardcoded Noto Sans CJK SC only covers Simplified Chinese. Now detects the specific CJK language (Japanese Kana, Korean Hangul, or Chinese Hanzi) and selects the appropriate font variant (JP/KR/SC). Changes: - Add detectCJKFont() that reads the source file and returns the correct Noto Sans CJK variant, or null for non-CJK content - CJK font argument is only added when detectCJKFont returns non-null - Detection order: Japanese (Kana) > Korean (Hangul) > Chinese (Hanzi) since Japanese also uses Kanji shared with Chinese - Graceful fallback: if file can't be read, no CJK font is added - Update tests to use temp files with real CJK content (11 tests total)
201 lines
7.2 KiB
TypeScript
201 lines
7.2 KiB
TypeScript
import { beforeEach, expect, test, describe, afterEach } from "bun:test";
|
|
import { convert } from "../../src/converters/pandoc";
|
|
import type { ExecFileFn } from "../../src/converters/types";
|
|
import { writeFileSync, unlinkSync } from "node:fs";
|
|
import { join } from "node:path";
|
|
import { tmpdir } from "node:os";
|
|
|
|
describe("convert", () => {
|
|
let mockExecFile: ExecFileFn;
|
|
let tempFiles: string[] = [];
|
|
|
|
afterEach(() => {
|
|
for (const f of tempFiles) {
|
|
try {
|
|
unlinkSync(f);
|
|
} catch {
|
|
/* ignore */
|
|
}
|
|
}
|
|
tempFiles = [];
|
|
});
|
|
|
|
function makeTempFile(content: string, ext = "md"): string {
|
|
const path = join(
|
|
tmpdir(),
|
|
`pandoc-test-${Date.now()}-${Math.random().toString(36).slice(2)}.${ext}`,
|
|
);
|
|
writeFileSync(path, content, "utf-8");
|
|
tempFiles.push(path);
|
|
return path;
|
|
}
|
|
|
|
beforeEach(() => {
|
|
mockExecFile = (cmd, args, callback) => callback(null, "output-data", "");
|
|
});
|
|
|
|
test("should call pandoc with correct arguments (normal)", async () => {
|
|
let calledArgs: Parameters<ExecFileFn> = ["", [], () => {}];
|
|
mockExecFile = (cmd, args, callback) => {
|
|
calledArgs = [cmd, args, callback];
|
|
callback(null, "output-data", "");
|
|
};
|
|
|
|
const result = await convert(
|
|
"input.md",
|
|
"markdown",
|
|
"html",
|
|
"output.html",
|
|
undefined,
|
|
mockExecFile,
|
|
);
|
|
|
|
expect(calledArgs[0]).toBe("pandoc");
|
|
expect(calledArgs[1]).toEqual([
|
|
"input.md",
|
|
"-f",
|
|
"markdown",
|
|
"-t",
|
|
"html",
|
|
"-o",
|
|
"output.html",
|
|
]);
|
|
expect(result).toBe("Done");
|
|
});
|
|
|
|
test("should add xelatex argument for pdf/latex", async () => {
|
|
let calledArgs: Parameters<ExecFileFn> = ["", [], () => {}];
|
|
mockExecFile = (cmd, args, callback) => {
|
|
calledArgs = [cmd, args, callback];
|
|
callback(null, "output-data", "");
|
|
};
|
|
|
|
const filePath = makeTempFile("# Hello World\n");
|
|
await convert(filePath, "markdown", "pdf", "output.pdf", undefined, mockExecFile);
|
|
|
|
expect(calledArgs[1][0]).toBe("--pdf-engine=xelatex");
|
|
expect(calledArgs[1]).toContain(filePath);
|
|
expect(calledArgs[1]).toContain("-f");
|
|
expect(calledArgs[1]).toContain("markdown");
|
|
expect(calledArgs[1]).toContain("-t");
|
|
expect(calledArgs[1]).toContain("pdf");
|
|
expect(calledArgs[1]).toContain("-o");
|
|
expect(calledArgs[1]).toContain("output.pdf");
|
|
});
|
|
|
|
test("should not add CJK mainfont for non-CJK content", async () => {
|
|
let calledArgs: Parameters<ExecFileFn> = ["", [], () => {}];
|
|
mockExecFile = (cmd, args, callback) => {
|
|
calledArgs = [cmd, args, callback];
|
|
callback(null, "output-data", "");
|
|
};
|
|
|
|
const filePath = makeTempFile("# Hello World\nThis is English text.\n");
|
|
await convert(filePath, "markdown", "pdf", "output.pdf", undefined, mockExecFile);
|
|
|
|
expect(calledArgs[1].some((arg) => arg.startsWith("CJKmainfont"))).toBe(false);
|
|
});
|
|
|
|
test("should add CJKmainfont=SC for Chinese content", async () => {
|
|
let calledArgs: Parameters<ExecFileFn> = ["", [], () => {}];
|
|
mockExecFile = (cmd, args, callback) => {
|
|
calledArgs = [cmd, args, callback];
|
|
callback(null, "output-data", "");
|
|
};
|
|
|
|
const filePath = makeTempFile("# 中文标题\n这是一段中文内容。\n");
|
|
await convert(filePath, "markdown", "pdf", "output.pdf", undefined, mockExecFile);
|
|
|
|
expect(calledArgs[1].some((arg) => arg === "CJKmainfont=Noto Sans CJK SC")).toBe(true);
|
|
});
|
|
|
|
test("should add CJKmainfont=JP for Japanese content", async () => {
|
|
let calledArgs: Parameters<ExecFileFn> = ["", [], () => {}];
|
|
mockExecFile = (cmd, args, callback) => {
|
|
calledArgs = [cmd, args, callback];
|
|
callback(null, "output-data", "");
|
|
};
|
|
|
|
const filePath = makeTempFile("# 日本語タイトル\nこれは日本語の内容です。\n");
|
|
await convert(filePath, "markdown", "pdf", "output.pdf", undefined, mockExecFile);
|
|
|
|
expect(calledArgs[1].some((arg) => arg === "CJKmainfont=Noto Sans CJK JP")).toBe(true);
|
|
});
|
|
|
|
test("should add CJKmainfont=KR for Korean content", async () => {
|
|
let calledArgs: Parameters<ExecFileFn> = ["", [], () => {}];
|
|
mockExecFile = (cmd, args, callback) => {
|
|
calledArgs = [cmd, args, callback];
|
|
callback(null, "output-data", "");
|
|
};
|
|
|
|
const filePath = makeTempFile("# 한국어 제목\n이것은 한국어 내용입니다.\n");
|
|
await convert(filePath, "markdown", "pdf", "output.pdf", undefined, mockExecFile);
|
|
|
|
expect(calledArgs[1].some((arg) => arg === "CJKmainfont=Noto Sans CJK KR")).toBe(true);
|
|
});
|
|
|
|
test("should prefer Japanese font when both Kanji and Kana present", async () => {
|
|
let calledArgs: Parameters<ExecFileFn> = ["", [], () => {}];
|
|
mockExecFile = (cmd, args, callback) => {
|
|
calledArgs = [cmd, args, callback];
|
|
callback(null, "output-data", "");
|
|
};
|
|
|
|
// Japanese text with both Kanji and Hiragana
|
|
const filePath = makeTempFile("# 日本語のテスト\nこれは漢字とひらがなの文章です。\n");
|
|
await convert(filePath, "markdown", "pdf", "output.pdf", undefined, mockExecFile);
|
|
|
|
expect(calledArgs[1].some((arg) => arg === "CJKmainfont=Noto Sans CJK JP")).toBe(true);
|
|
expect(calledArgs[1].some((arg) => arg === "CJKmainfont=Noto Sans CJK SC")).toBe(false);
|
|
});
|
|
|
|
test("should not add CJK mainfont for latex when content is non-CJK", async () => {
|
|
let calledArgs: Parameters<ExecFileFn> = ["", [], () => {}];
|
|
mockExecFile = (cmd, args, callback) => {
|
|
calledArgs = [cmd, args, callback];
|
|
callback(null, "output-data", "");
|
|
};
|
|
|
|
const filePath = makeTempFile("# English Title\nSome text.\n");
|
|
await convert(filePath, "markdown", "latex", "output.tex", undefined, mockExecFile);
|
|
|
|
expect(calledArgs[1][0]).toBe("--pdf-engine=xelatex");
|
|
expect(calledArgs[1].some((arg) => arg.startsWith("CJKmainfont"))).toBe(false);
|
|
});
|
|
|
|
test("should not add CJK mainfont for non-pdf/latex output", async () => {
|
|
let calledArgs: Parameters<ExecFileFn> = ["", [], () => {}];
|
|
mockExecFile = (cmd, args, callback) => {
|
|
calledArgs = [cmd, args, callback];
|
|
callback(null, "output-data", "");
|
|
};
|
|
|
|
const filePath = makeTempFile("# 中文标题\n");
|
|
await convert(filePath, "markdown", "html", "output.html", undefined, mockExecFile);
|
|
|
|
expect(calledArgs[1].some((arg) => arg.startsWith("CJKmainfont"))).toBe(false);
|
|
});
|
|
|
|
test("should handle unreadable file gracefully without CJK font", async () => {
|
|
let calledArgs: Parameters<ExecFileFn> = ["", [], () => {}];
|
|
mockExecFile = (cmd, args, callback) => {
|
|
calledArgs = [cmd, args, callback];
|
|
callback(null, "output-data", "");
|
|
};
|
|
|
|
// Use a non-existent file path
|
|
await convert("/nonexistent/file.md", "markdown", "pdf", "output.pdf", undefined, mockExecFile);
|
|
|
|
expect(calledArgs[1][0]).toBe("--pdf-engine=xelatex");
|
|
expect(calledArgs[1].some((arg) => arg.startsWith("CJKmainfont"))).toBe(false);
|
|
});
|
|
|
|
test("should reject if execFile returns an error", async () => {
|
|
const filePath = makeTempFile("# Test\n");
|
|
mockExecFile = (cmd, args, callback) => callback(new Error("fail"), "", "");
|
|
await expect(
|
|
convert(filePath, "markdown", "html", "output.html", undefined, mockExecFile),
|
|
).rejects.toMatch(/error: Error: fail/);
|
|
});
|
|
});
|